Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing options to resolve #2009

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jimbly
Copy link

@Jimbly Jimbly commented May 14, 2021

This allows passing options such as readFile/isFile/isDirectory down to resolve.

I needed this while integrating browserify into a new build system that tracks dependencies for minimal rebuilds. The existing hooks (persistentCache and such) only get called if a file exists (was found by resolve), so if resolve doesn't find a particular file, and that file is added later, there's no evidence in any of our recorded dependencies that the bundle needs to be regenerated. Additionally, without this, it seems there's no way to cache (or load from a virtual file system) the package.json files resolve is loading when resolving dependencies.

Is there something already existing that I'm missing that would provide this information?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant