New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: Update buffer to ^6.0.3 #1988
base: master
Are you sure you want to change the base?
Conversation
BREAKING: Drop IE11, Safari 9-10 support Since Buffer now supports the BigInt methods and the code for that uses the exponentiation operator, we decided to drop support for IE11 and Safari 9-10 from `buffer`.
Nice. I think dropping IE 11 is quite a significant step (moreso than any other IE version), so I'd prefer to make it easier to swap out builtins consistently in both the API and CLI before we actually publish this. |
@goto-bus-stop I think we dropped IE8-10 when it had a similar amount of usage (see: #1678) but if it makes you more comfortable, I'm okay with waiting until usage has declined further or it has become easier to swap out built-ins in the API. :) Btw, since I sent this PR, IE11 usage has declined from 1.16% to 1.09%. https://caniuse.com/usage-table |
1% is still 4.6 million people - I'd prefer we don't reduce human beings to percentages. |
Just a quick note that since I sent this PR, IE11 usage has declined from 1.16% to 1.00%.
Lol, it goes without saying that each human being is unique and special. By that logic, we can't ever drop support for anything because we can't "reduce human beings to percentages". We've dropped support for browsers when they reached similar usage numbers in the past. See: #1678 Also, keep in mind that releasing a new major version of |
Unless future features and bugfixes are backported to that version of browserify, it does indeed mean they miss out on those. |
I don't think I'll have the time and interest to work on a feature for replacing builtins in plugins in the near future, so maybe the next best thing is to merge this as is and document that users can do |
0.85% now 😄 |
0.76%, we should set the threshold at 0.5% |
Update buffer to ^6.0.3
Browser support
BREAKING: Drop IE11, Safari 9-10 support. This affects ~1.16% of global browser users (source: https://caniuse.com/usage-table) and this number continues to decrease each month.
Since
buffer
now supports the newly addedBigInt
methods from Node.js and the implementation uses the exponentiation operator throughout, we decided to drop support for IE11 and Safari 9-10 frombuffer
.Similar to previous
buffer
upgrades (e.g. #1678), users can manually specify an olderbuffer
version if they need IE11 and Safari 9-10 support. More information about how to do this can be found in: #1980Semver
This should be released as semver major.