Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ci, skip broken tests in old node.js #1982

Merged
merged 2 commits into from Oct 9, 2020
Merged

fix ci, skip broken tests in old node.js #1982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
190491a
update min insert-module-globals version
goto-bus-stop Oct 9, 2020
e34ed8c
skip crypto tests in old node.js
goto-bus-stop Oct 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -44,7 +44,7 @@
"htmlescape": "^1.1.0",
"https-browserify": "^1.0.0",
"inherits": "~2.0.1",
"insert-module-globals": "^7.0.0",
"insert-module-globals": "^7.2.1",
"labeled-stream-splicer": "^2.0.0",
"mkdirp-classic": "^0.5.2",
"module-deps": "^6.2.3",
Expand Down
4 changes: 3 additions & 1 deletion test/crypto.js
View file
Open in desktop
Expand Up @@ -4,6 +4,7 @@ var path = require('path');
var fs = require('fs');
var vm = require('vm');
var concat = require('concat-stream');
var semver = require('semver');

var temp = require('temp');
temp.track();
Expand All @@ -13,7 +14,8 @@ fs.writeFileSync(tmpdir + '/main.js', 'beep(require("crypto"))\n');

if (!ArrayBuffer.isView) ArrayBuffer.isView = function () { return false; };

test('*-browserify libs from node_modules/', function (t) {
// `crypto-browserify` no longer works in node.js <4
test('*-browserify libs from node_modules/', { skip: semver.lt(process.version, 'v4.0.0') }, function (t) {
t.plan(2);

var bin = __dirname + '/../bin/cmd.js';
Expand Down
4 changes: 3 additions & 1 deletion test/crypto_ig.js
View file
Open in desktop
Expand Up @@ -4,6 +4,7 @@ var path = require('path');
var fs = require('fs');
var vm = require('vm');
var concat = require('concat-stream');
var semver = require('semver');

var temp = require('temp');
temp.track();
Expand All @@ -13,7 +14,8 @@ fs.writeFileSync(tmpdir + '/main.js', 'beep(require("crypto"))\n');

if (!ArrayBuffer.isView) ArrayBuffer.isView = function () { return false; };

test('crypto --insertGlobals', function (t) {
// `crypto-browserify` no longer works in node.js <4
test('crypto --insertGlobals', { skip: semver.lt(process.version, 'v4.0.0') }, function (t) {
t.plan(2);

var bin = __dirname + '/../bin/cmd.js';
Expand Down