Browser resolve direct #1887
Open
Browser resolve direct #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Nov 28, 2018
| @@ -40,7 +40,7 @@ function Browserify (files, opts) { | |||
| var self = this; | |||
| if (!(this instanceof Browserify)) return new Browserify(files, opts); | |||
| if (!opts) opts = {}; | |||
|
|
|||
There was a problem hiding this comment.
please revert all these unrelated whitespace changes.
There was a problem hiding this comment.
Sublime automatically cleans up trailing whitespaces. Not sure I understand what is the meaning of keeping them.
Bah, sad to see there is no way for my contributions.
There was a problem hiding this comment.
i wouldn't keep them in most situations, but browserify is old and most of the code was written by people who no longer maintain it, so history tools like git blame are important for people like me who have no idea why things are the way they are a lot of the time 😅 minimal patches are valuable in that respect.
thanks for the test, i hope we can get the browser-resolve patch in soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds #1539 test for now.
Will be fixed once browserify/browser-resolve#84 is merged.