Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide test cases for --list #1874

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Provide test cases for --list #1874

wants to merge 6 commits into from

Conversation

casr
Copy link

@casr casr commented Oct 26, 2018

Before attempting to fix this I thought I would provide a test for the current behaviour and one for the failing behaviour from #1873

It would be good to understand if this is the right approach to testing this sort of thing.

Before merging it might be nice to fix the feature but if this takes longer than expected then one test can go in and the other be skipped until someone has the time to fix it

@goto-bus-stop
Copy link
Member

Super, thanks 👍 the test looks good to me from just eyeballing it, not sure off the top of my head if the order is guaranteed. I think the solution to this problem will involve setting the row.file property correctly for --require/b.require() modules either here or in module-deps.

@casr
Copy link
Author

casr commented Oct 28, 2018

Thank you for having a look and a good note about ordering. I guess I could sort before comparing in the test unless the ordering is guaranteed elsewhere. I will add a note if I find that to be the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants