Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dep round trip #1415

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Dep round trip #1415

wants to merge 2 commits into from

Commits on Oct 26, 2015

  1. add failing test that tries to round-trip dep 

    Browserify-incremental makes the assumption that we can round-trip `dep` events
(slightly mutated to form an object with `row.file` as the key) back into the
cache with no ill effects.  This is true except for the edge case shown here -
when you are both exposing a module and requiring it in the same bundle.
    Aaron Dufour committed Oct 26, 2015
    Configuration menu
    Copy the full SHA
    e8cd685 View commit details
    Browse the repository at this point in the history

  2. fix failing test about exposing and requiring the same module 

    It should be safe to not walk down an exposed module, since it's being taken
care of at the top-level.  If we don't do this, `module-deps` tries to open a
file using the module's exposed name rather than a valid filename, which errors
out.

This is only triggered by passing in a cache value that should be valid.
    Aaron Dufour committed Oct 26, 2015
    Configuration menu
    Copy the full SHA
    d0f53ac View commit details
    Browse the repository at this point in the history