Skip to content

Commit

Permalink
Set CI to false to continue deploying when we see certain webpack war…
Browse files Browse the repository at this point in the history 
…nings

Right now we see: Critical dependency: the request of a dependency is an expression

I've tracked it somewhat to the need to do a big update in Stopify from
babel-core to @babel/core. That's going to be an undertaking, so allowing the
build to finish with these warnings and still deploy.
  • Loading branch information
@jpolitz
jpolitz committed Sep 20, 2019
1 parent 3a9fbcd commit e1f7fac
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .travis.yml
View file
Expand Up @@ -29,7 +29,9 @@ after_failure:
before_deploy:
- cd ide
- npm install
- npm run build
- echo "NOTE(joe): CI=false below avoids stopping the build on warnings from webpack about require() targets"
- echo "NOTE(joe): We want to see them, but not be blocked on them"
- CI=false npm run build
deploy:
provider: s3
access_key_id: "AKIAUCA3RRQKLUSZTBS5"
Expand Down

2 comments on commit e1f7fac

@jpolitz
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity: babel/babel#9754

@jpolitz
Copy link
Member Author

@jpolitz jpolitz commented on e1f7fac Sep 20, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also for posterity:

70.33s$ npm run build
> ide@0.1.0 build /home/travis/build/brownplt/pyret-lang/ide
> node scripts/build.js
Creating an optimized production build...
Treating warnings as errors because process.env.CI = true.
Most CI servers set it automatically.
Failed to compile.
./node_modules/babel-core/lib/transformation/file/options/option-manager.js
Critical dependency: the request of a dependency is an expression

Note the Treating warnings as errors bit, that's what CI=false is for.

Please sign in to comment.