Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ES6 import for consistency #84

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use ES6 import for consistency #84

wants to merge 2 commits into from

Conversation

PrismPrince
Copy link

No description provided.

BrockReece
BrockReece approved these changes May 27, 2018
View reviewed changes
Copy link
Collaborator

@BrockReece BrockReece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me especially as our tests use import statements, rather than require.

@BrockReece
Copy link
Collaborator

Could we pull in the latest changes from master to make sure everything is consistent?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrockReece BrockReece BrockReece approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PrismPrince @BrockReece