Ordering inputFiles (all conflicts fixed) #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codynguyen
force-pushed
the
ordering-input-files
branch
from
b25b6ea
to
3bbc5f3
Compare
|
left a comment: #96 (comment), lets discuss there. But I'm down with exploring landing this soon. |
|
mind doing a rebase, it looks like recent changes have introduced additional conflicts. With that, we can move forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #96 has been around for quite some time and there's conflicts. Doesn't seem to be merged soon.
So I decided to branch out from latest master branch and copy the changes over. I also fixed some typos here and there.
Hope someone has time to take a look!