Fix update of node-fetch for vulnerability (SCP-4029) #1332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a security vulnerability in
node-fetch
in a way that doesn't break SCP automated tests.Dependabot bumped
node-fetch
up a major version to fix a vulnerability (#1326). The test failed with a false positive as noted there, but a true positive failure also occurred, went unnoticed, and now consistently breaks CI. The true-positive was caused by breaking changes in the majornode-fetch
update.Further research indicates the vulnerability can be fixed by a minor
node-fetch
update, to version 2.6.7. This change does that. Local testing indicates it works.To test:
yarn install
yarn test
This satisfies SCP-4029.