Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update of node-fetch for vulnerability (SCP-4029) #1332

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

eweitz
Copy link
Member

@eweitz eweitz commented Jan 25, 2022

This fixes a security vulnerability in node-fetch in a way that doesn't break SCP automated tests.

Dependabot bumped node-fetch up a major version to fix a vulnerability (#1326). The test failed with a false positive as noted there, but a true positive failure also occurred, went unnoticed, and now consistently breaks CI. The true-positive was caused by breaking changes in the major node-fetch update.

Further research indicates the vulnerability can be fixed by a minor node-fetch update, to version 2.6.7. This change does that. Local testing indicates it works.

To test:

  • Pull
  • yarn install
  • yarn test
  • Confirm tests pass

This satisfies SCP-4029.

@ehanna4 ehanna4 merged commit 292dd54 into development Jan 25, 2022
@bistline bistline deleted the ew-upgrade-node-fetch branch March 1, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants