Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDO-2918] Remove uncalled v1 code; add API diff checker action #191

Merged
merged 15 commits into from
Jun 21, 2023

whoops

5df768c
Select commit
Failed to load commit list.
Merged

[DDO-2918] Remove uncalled v1 code; add API diff checker action #191

whoops
5df768c
Select commit
Failed to load commit list.
Codecov / codecov/project succeeded Jun 21, 2023 in 1s

51.41% (-2.14%) compared to 34a37ea, passed because coverage was not affected by patch

View this Pull Request on Codecov

51.41% (-2.14%) compared to 34a37ea, passed because coverage was not affected by patch

Details

Codecov Report

Patch coverage has no change and project coverage change: -2.14 ⚠️

Comparison is base (34a37ea) 53.55% compared to head (5df768c) 51.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
- Coverage   53.55%   51.41%   -2.14%     
==========================================
  Files          66       52      -14     
  Lines        5445     4913     -532     
==========================================
- Hits         2916     2526     -390     
+ Misses       2389     2257     -132     
+ Partials      140      130      -10     
Impacted Files Coverage Δ
sherlock/internal/db/connect.go 0.00% <ø> (ø)
sherlock/internal/db/test_helpers.go 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.