Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API phpunit 9 support #167

Merged
merged 1 commit into from Nov 10, 2021
Merged

API phpunit 9 support #167

merged 1 commit into from Nov 10, 2021

Conversation

emteknetnz
Copy link
Collaborator

@emteknetnz emteknetnz mentioned this pull request Nov 3, 2021
Closed
93 tasks
@emteknetnz emteknetnz marked this pull request as draft November 4, 2021 03:22
@emteknetnz emteknetnz marked this pull request as ready for review November 5, 2021 01:04
maxime-rainville
maxime-rainville requested changes Nov 8, 2021
View reviewed changes
Copy link
Collaborator

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK ... but build is failing.

@emteknetnz emteknetnz mentioned this pull request Nov 9, 2021
Merged
@emteknetnz
Copy link
Collaborator Author

@maxime-rainville build is passing now

maxime-rainville
maxime-rainville approved these changes Nov 10, 2021
View reviewed changes
Copy link
Collaborator

@maxime-rainville maxime-rainville left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... but I don't have access to merge

@emteknetnz emteknetnz merged commit dc24500 into bringyourownideas:2 Nov 10, 2021
@emteknetnz emteknetnz deleted the pull/2/sapphire-test-nine branch November 10, 2021 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-rainville maxime-rainville maxime-rainville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emteknetnz @maxime-rainville