Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy required types from @types/amqplib #71

Closed
wants to merge 2 commits into from
Closed

Copy required types from @types/amqplib #71

wants to merge 2 commits into from

Conversation

ramhr
Copy link
Contributor

@ramhr ramhr commented Mar 24, 2024

In order to not force users of the arnavmq package to also install the entire @types/amqplib for their project to compile.

@shamil
Copy link
Member

shamil commented Mar 25, 2024

@ramhr as discussed please use amqplb types as dependency instead of copying the types to the repo

@ramhr
Copy link
Contributor Author

ramhr commented Mar 25, 2024

See #72

@ramhr ramhr closed this Mar 25, 2024
@ramhr ramhr deleted the remove_types_dependency branch March 25, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korichdaniel korichdaniel korichdaniel approved these changes

@shamil shamil Awaiting requested review from shamil shamil is a code owner

@yosiat yosiat Awaiting requested review from yosiat yosiat is a code owner

Assignees

@ramhr ramhr

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ramhr @shamil @korichdaniel