remove p-defer and use crypto.randomUUID if available #38
Conversation
rluvaton
changed the title
| @@ -8,6 +8,17 @@ const emptyLogger = { | |||
| log: empty | |||
| }; | |||
|
|
|||
| let uuidV4; | |||
| const crypto = require('crypto'); | |||
There was a problem hiding this comment.
we can't use uuid from crypto package yet, since this module still retains support for node 12
There was a problem hiding this comment.
this is why I check in line 14 if the function is defined...
There was a problem hiding this comment.
right, so if you keep the uuid package anyway, why doing this magic, lets stick with single version and once we deprecate node 12 we will move to version from crypto package and remove the uuid module. I prefer to stay consistent between versions, the performance gain is not that crucual.
There was a problem hiding this comment.
The randomUUID is 12 times faster but as you wish...
There was a problem hiding this comment.
@rluvaton just update to uuid version 9.. it will crypto.randomUUID if it's available (uuidjs/uuid#600)
| @@ -29,7 +29,6 @@ | |||
| "homepage": "https://github.com/bringg/node-arnavmq#readme", | |||
| "dependencies": { | |||
| "amqplib": "^0.10.3", | |||
| "p-defer": "^3.0.0", | |||
There was a problem hiding this comment.
we actually had an own version of this, but decided to use this package to avoid managing custom version, so please lets keep it.
There was a problem hiding this comment.
No management is required in this it's just 4 lines of simple code...
There was a problem hiding this comment.
as explained earlier we had this already and it was decided to remove from the codebase, p-defer is commonly used package and downloaded 8 million times a day. Lets please stick with it.
| @@ -8,6 +8,17 @@ const emptyLogger = { | |||
| log: empty | |||
| }; | |||
|
|
|||
| let uuidV4; | |||
| const crypto = require('crypto'); | |||
There was a problem hiding this comment.
right, so if you keep the uuid package anyway, why doing this magic, lets stick with single version and once we deprecate node 12 we will move to version from crypto package and remove the uuid module. I prefer to stay consistent between versions, the performance gain is not that crucual.
No description provided.