Add resolution for NPM package lodash due to security vulnerability #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Radu M <root@radu.sh>
radu-matei
requested review from
adamreese,
lukepatrick,
mumoshu,
technosophos and
vdice
as code owners
|
Deploy preview for brigade-docs ready! Built with commit 0162a8f |
vdice
approved these changes
Jul 17, 2019
dgkanatsios
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our dev dependencies (
typedoc) has a dependency onlodash- https://github.com/TypeStrong/typedoc/blob/master/package.json#L37, which has a known vulnerability - lodash/lodash#4336This PR adds a
resolutionssection inpackage.json, according to https://yarnpkg.com/lang/en/docs/selective-version-resolutions.Since it's a dependency of a dev dependency, it means we don't actually ship this package in our worker image, but we should update it nonetheless.
When
typedocreleases a new version, we could remove the manual resolution.