Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SSR tests to work with Rack 3 #627

Merged
merged 1 commit into from Sep 18, 2022

Conversation

neilvanbeinum
Copy link
Contributor

This is a 馃檵 feature or enhancement.

Summary

  • Adding require "rack" because Rack no longer seems to be loaded. (Wasn't sure why this was now needed though 馃.)
  • Remove call to .first on the return value from Rack::Builder.parse_file - in Rack's latest version, just the app is returned rather than an array.

@jaredcwhite
Copy link
Member

@vvveebs Thanks for tracking that down!

@jaredcwhite jaredcwhite merged commit a704170 into bridgetownrb:main Sep 18, 2022
@neilvanbeinum neilvanbeinum deleted the fixes-following-rack-3 branch September 18, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants