-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Apple visionOS support #2032
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Have you tested this on visionOS hardware and in the simulator?
Thank you for the review. It's clearer now how ring works. The change is much simpler! And yes, I tested it; the app is even on the App Store :) . |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2032 +/- ##
==========================================
+ Coverage 97.24% 97.35% +0.10%
==========================================
Files 144 142 -2
Lines 19998 19915 -83
Branches 228 228
==========================================
- Hits 19447 19388 -59
+ Misses 525 500 -25
- Partials 26 27 +1 ☔ View full report in Codecov by Sentry. |
Hello! I'm curious if this same change would be required to add support for |
@QuentinPerez could you please rebase this on top of the latest changes on the main branch. The recent changes should result in it being even simpler now. |
There are several watchos targets, some of which are easier to support than others. PR #1914 started to add support for watchOS, but it got closed before it was finished. I suggest you pick where that left off. |
@@ -175,7 +175,7 @@ wasm-bindgen-test = { version = "0.3.37", default-features = false } | |||
libc = { version = "0.2.148", default-features = false } | |||
|
|||
[build-dependencies] | |||
cc = { version = "1.0.83", default-features = false } | |||
cc = { version = "1.0.94", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the oldest cc-rs that is known to work for this? Because of issues like rust-lang/cc-rs#984 I'm weary of forcing users to update to too-new version of cc-rs right now, if we can avoid it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Motivation
Add the support of Apple VisionOS 121419
Solution
Add target_os = "visionos"