Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use Ubuntu 20.04 in GitHub Actions. #1524

Merged
merged 1 commit into from
Oct 27, 2022
Merged

CI: Use Ubuntu 20.04 in GitHub Actions. #1524

merged 1 commit into from
Oct 27, 2022

Conversation

briansmith
Copy link
Owner

"The Ubuntu 18.04 Actions runner image is being deprecated and will be removed by 12/1/22" according to the GitHub Changelog blog.

@briansmith briansmith self-assigned this Oct 20, 2022
@briansmith briansmith force-pushed the b/ubuntu-20.04 branch 3 times, most recently from 907f548 to 993da11 Compare October 21, 2022 03:54
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #1524 (300f58c) into main (00fc3f3) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 300f58c differs from pull request most recent head b5d1748. Consider uploading reports for the commit b5d1748 to get more accurate results

@@            Coverage Diff             @@
##             main    #1524      +/-   ##
==========================================
- Coverage   91.47%   91.46%   -0.02%     
==========================================
  Files         128      130       +2     
  Lines       18801    18819      +18     
  Branches      195      195              
==========================================
+ Hits        17198    17212      +14     
- Misses       1568     1572       +4     
  Partials       35       35              
Impacted Files Coverage Δ
src/aead/shift.rs 37.03% <0.00%> (-2.97%) ⬇️
src/rand.rs 64.63% <0.00%> (-1.65%) ⬇️
src/polyfill/array_flat_map.rs 95.12% <0.00%> (-0.99%) ⬇️
tests/agreement_tests.rs 90.68% <0.00%> (-0.57%) ⬇️
src/aead/aes.rs 80.76% <0.00%> (-0.49%) ⬇️
src/aead.rs 70.00% <0.00%> (ø)
src/digest.rs 97.02% <0.00%> (ø)
src/aead/quic.rs 65.07% <0.00%> (ø)
src/aead/nonce.rs 100.00% <0.00%> (ø)
src/aead/chacha.rs 99.43% <0.00%> (ø)
... and 13 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@briansmith briansmith force-pushed the b/ubuntu-20.04 branch 8 times, most recently from c914b5d to a868d4f Compare October 26, 2022 18:09
"The Ubuntu 18.04 Actions runner image is being deprecated and will be
removed by 12/1/22" according to the GitHub Changelog blog.

Temporarily disable wasm32 tests using Firefox until the Ubuntu 22.04
runners are set up correctly.
@briansmith
Copy link
Owner Author

briansmith commented Oct 26, 2022

One problem here is that Firefox and geckodriver aren't in the Ubuntu 22.04 images. In this PR I've just disabled the testing in Firefox. We could move that testing to Windows (like getrandomdid, IIRC) but for now I've just commented out the Firefox testing so that Chrome is the only browser tested. See the comments mentioning Firefox in actions/runner-images#6399 for more info.

@briansmith briansmith merged commit 6906cc1 into main Oct 27, 2022
@briansmith briansmith deleted the b/ubuntu-20.04 branch October 27, 2022 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant