Skip to content

Commit

Permalink
Revert "Do not show colors in Windows CMD & Powershell (#138)" (#140)
Browse files Browse the repository at this point in the history
This reverts commit 8c5f2aa.
  • Loading branch information
briandowns committed Apr 22, 2022
1 parent 8c5f2aa commit f878506
Showing 1 changed file with 2 additions and 9 deletions.
11 changes: 2 additions & 9 deletions spinner.go
Expand Up @@ -100,8 +100,7 @@ var validColors = map[string]bool{
}

// returns true if the OS is windows and the WT_SESSION env variable is set.
var isWindows = runtime.OSOS == "windows"
var isWindowsTerminalOnWindows = len(os.Getenv("WT_SESSION")) > 0 && isWindows
var isWindowsTerminalOnWindows = len(os.Getenv("WT_SESSION")) > 0 && runtime.GOOS == "windows"

// returns a valid color's foreground text color attribute
var colorAttributeMap = map[string]color.Attribute{
Expand Down Expand Up @@ -282,12 +281,6 @@ func (s *Spinner) Start() {
// hides the cursor
fmt.Fprint(s.Writer, "\033[?25l")
}
// Disable colors for simple Windows CMD or Powershell
// as they can not recognize them
if isWindows && !isWindowsTerminalOnWindows {
color.NoColor = true
}

s.active = true
s.mu.Unlock()

Expand All @@ -312,7 +305,7 @@ func (s *Spinner) Start() {
}

var outColor string
if isWindows {
if runtime.GOOS == "windows" {
if s.Writer == os.Stderr {
outColor = fmt.Sprintf("\r%s%s%s", s.Prefix, s.chars[i], s.Suffix)
} else {
Expand Down

0 comments on commit f878506

Please sign in to comment.