Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-125413 Use new ImageSelector component in image-selector tag and remove old one #98928

Closed
wants to merge 8 commits into from
Closed

LPS-125413 Use new ImageSelector component in image-selector tag and remove old one #98928

wants to merge 8 commits into from

Commits on Feb 11, 2021

  1. LPS-125413 Move get imageURL logic to Tag. Deprecate draggableImage a… 

    …ttribute in favor of imageCropDirection. Add isDraggable logic to Tag.
    Carlos Lancha committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    c7b61db View commit details
    Browse the repository at this point in the history

  2. LPS-125413 Update image selector jsp, removing no needed code in SSR … 

    …and using new ImageSelector react component
    Carlos Lancha committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    dc8cc4c View commit details
    Browse the repository at this point in the history

  3. LPS-125413 Add missing class

    Carlos Lancha committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    0ea6ce1 View commit details
    Browse the repository at this point in the history

  4. LPS-125413 Get rid of useCallback usages since they're not needed. Re… 

    …name some methods to improve naming consistency. Add missing markup. Update props to fit new API from tag.
    Carlos Lancha committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    c3ff480 View commit details
    Browse the repository at this point in the history

  5. LPS-125413 Added missing ids

    Carlos Lancha committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    3857d88 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2021

  1. LPS-125413 Fix poshi test: select file is a button, not a link

    Carlos Lancha committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    b682e28 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2021

  1. LPS-125413 baseLine

    Carlos Lancha committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    b8910d9 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2021

  1. LPS-125413 Fix path due to changes to image_selector/page.jsp

    @nikki-pru
    nikki-pru authored and Carlos Lancha committed Feb 18, 2021
    Configuration menu
    Copy the full SHA
    5c0eaea View commit details
    Browse the repository at this point in the history