Turn Cursor into an ES6 class #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charmander
requested changes
May 28, 2021
charmander
requested changes
May 30, 2021
|
Sorry for the delay here - really appreciate this! Merging now. You marked this as a breaking change but none of the tests needed to change - is this a semver major thing? I'm fine either way & can release it however you think is best. |
Did I? This shouldn't be breaking yes. |
Bluenix2
added a commit
to Bluenix2/node-postgres
that referenced
this pull request
Jun 22, 2021
* Turn Cursor into an ES6 class * Fix incorrect syntax in Cursor.end() * Remove extraneous empty line * Revert es6 change for end() * Revert back to defining the end() method inside the class * Use hanging indent to satisfy Prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike most other objects Cursor has remained unchanged to an ES6 class. As somewhat expected the git diff is kind of a mess when changes like these happen, I don't think there's anything that can be done considering everything had to be indented an additional time.