Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haldex bugfixes & General Housekeeping #105

Merged
merged 8 commits into from
Sep 3, 2023
Merged

Conversation

ConnorHowell
Copy link
Contributor

I can probably split this up into seperate PR's if it's easier.

Summary of changes

  • Removed ESP flashing related utilities
  • Removed BLE (UART & J2534 only now)
  • Fixed pillow dep for GH Actions building (32 bit wheels were dropped and building from source wasn't working; resorted to prebuilt only) (Add support for Python 3.12 python-pillow/Pillow#6941)
  • Corrected Haldex checksumming (correct checksums were generated.... just not applied to the binary before flashing!!)
  • Implemented support for varying length Haldex calibrations. (This may be considered kinda hacky; the block length is at offset 0x14 from the start of the CAL so it's pulled from there for blocks_from_bin. To correct the length used for RequestDownload the block length is set to the length of the binary in haldex_flash_utils.py

- Earlier revision haldex units have a cal length of 0x333E
- Newer versions have a cal length of 0x353A
- Also hopefully fixes github actions
- New ESP32 firmware is password locked for BLE/BT Classic use
- The UART connection still exists so this is preferred
- Python-Pillow (req'd by wxpython) no longer provides 32bit wheels.
@bri3d
Copy link
Owner

bri3d commented Sep 3, 2023

LGTM. Next time we make a real release we'll have to do a writeup about the new J2534 stuff as well as try to get Switchleg to provide Linux+OSX binaries for it.

@bri3d bri3d merged commit 9c4711d into bri3d:master Sep 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants