Return null when applicable from getGeneratedKeys
#2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there is no way to check if `getGeneratedKeys` returned `null`. Instead, when trying to call `ResultSet.next()` a `NullPointerException` is thrown. This method [should return an empty `ResultSet` when there are no generated keys]( https://docs.oracle.com/javase/8/docs/api/java/sql/Statement.html#getGeneratedKeys--), but not all JDBC drivers do (like [Apache](https://github.com/apache/derby/blob/4253dcf4aa37dc64cf7235d494cd2f00f72e678a/java/org.apache.derby.client/org/apache/derby/client/am/ClientStatement.java#L271) [Derby](https://github.com/apache/derby/blob/4253dcf4aa37dc64cf7235d494cd2f00f72e678a/java/org.apache.derby.client/org/apache/derby/client/am/ClientStatement.java#L1378-L1394)) In these cases, I think the safest option is to return `null`, which can then be checked (and is checked in popular JDBC libraries [like JOOQ.](https://github.com/jOOQ/jOOQ/blob/181d838797d8238edd52576df6b7d3827cceb797/jOOQ/src/main/java/org/jooq/impl/AbstractDMLQuery.java#L1350-L1352))
Foulest
added a commit
to Foulest/HikariCP
that referenced
this pull request
May 5, 2024
- Pulled changes from brettwooldridge#2189 brettwooldridge#2180 brettwooldridge#2157 brettwooldridge#2149 brettwooldridge#2147 brettwooldridge#2133 brettwooldridge#2068 brettwooldridge#2065 brettwooldridge#2038 brettwooldridge#2035 brettwooldridge#2031 brettwooldridge#2010 (aside from code found in removed test functions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no way to check if
getGeneratedKeysreturnednull. Instead, when trying to callResultSet.next()aNullPointerExceptionis thrown.This method should return an empty
ResultSetwhen there are no generated keys, but not all JDBC drivers do (like Apache Derby) In these cases, I think the safest option is to returnnull, which can then be checked (and is checked in popular JDBC libraries like JOOQ.)