feat: supports metrics exemplars #2160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exemplars is only supported as part of 0.11.0 of simple-client.
Without this change, a prometheus scraper might fail scraping metrics out of HikariCP correctly. Ending up in unhealthy state. Due to, (as an example) "metric name hikaricp_connections_usage_seconds_count does not support exemplars".
One possible solution is to stop recording metrics out of hikaricp in the application via registry filters. But if we still want to use those nice metrics, this becomes a challenge.