LCM: Add TRACE logs for get, recycle and close in HikariPool as well … #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfbayer
reviewed
Sep 15, 2023
…as for main methods of ProxyConnection to be able to debug and analyse DB connection management.
|
@lfbayer |
|
@lfbayer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TRACE logs for get, recycle and close in HikariPool as well as for main methods of ProxyConnection to be able to debug and analyse DB connection management.
We would have loved to have some logs showing when a connection is borrowed from the pool and when it gets released to the pool.
That's why we enhanced the 2 classes
HikariPoolandProxyConnectionwith a few TRACE logs which let us observe the handling of the connection and understand the behaviour of our application much better.We would like to ask you to add this logging enhancement to the productive code.
Kind regards,
Valentin