Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uuid to identify connection timings #1992

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

chillosu
Copy link

For our use of HikariCP we have determined that the average duration of time between connection creation attempt and connection established can be an indicator for determining health between the application layer and the database.

AFAIK, there is no way current way to correlate an attempt at establishing a connection and the existing logging "Added connection", this is an attempt to change that.

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #1992 (65d3f3f) into dev (3a90fb9) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1992      +/-   ##
============================================
+ Coverage     70.37%   70.46%   +0.08%     
+ Complexity      572      570       -2     
============================================
  Files            26       26              
  Lines          2164     2167       +3     
  Branches        311      311              
============================================
+ Hits           1523     1527       +4     
+ Misses          492      487       -5     
- Partials        149      153       +4     
Impacted Files Coverage Δ
src/main/java/com/zaxxer/hikari/pool/PoolBase.java 72.92% <100.00%> (+2.48%) ⬆️
...ain/java/com/zaxxer/hikari/util/ConcurrentBag.java 71.27% <0.00%> (-5.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a90fb9...65d3f3f. Read the comment docs.

Copy link

@akashchouhan16 akashchouhan16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chillosu great addon for logs ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants