Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose whether pool is suspended in MXBean #1940

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ashok-square
Copy link

No description provided.

@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #1940 (b2e07b3) into dev (ed2da5f) will decrease coverage by 0.37%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1940      +/-   ##
============================================
- Coverage     70.75%   70.37%   -0.38%     
+ Complexity      575      573       -2     
============================================
  Files            26       26              
  Lines          2171     2167       -4     
  Branches        311      311              
============================================
- Hits           1536     1525      -11     
- Misses          484      493       +9     
+ Partials        151      149       -2     
Impacted Files Coverage Δ
...c/main/java/com/zaxxer/hikari/pool/HikariPool.java 80.51% <100.00%> (-0.63%) ⬇️
...in/java/com/zaxxer/hikari/pool/ProxyStatement.java 46.15% <0.00%> (-3.08%) ⬇️
src/main/java/com/zaxxer/hikari/pool/PoolBase.java 70.43% <0.00%> (-1.73%) ⬇️
...ain/java/com/zaxxer/hikari/util/ConcurrentBag.java 76.59% <0.00%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9147ee...b2e07b3. Read the comment docs.

@lfbayer
Copy link
Collaborator

lfbayer commented Oct 6, 2022

@ashok-square sorry to take so long to respond to this pull request.

Can you add a unit test to cover this new method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants