Prevent PrometheusHistogramMetricsTracker from registering metrics twice in the same CollectorRegistry #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reformat `PrometheusHistogramMetricsTrackerFactoryTest` using the project's Eclipse formatter profile like was done for `PrometheusMetricsTrackerFactoryTest` in 086bf18. This makes similiarities between the two files readily apparent. Also use class `StubPoolStats` instead of local implementation. Issue-Id: #1465
Autoformat `PrometheusHistogramMetricsTrackerFactory` using the project's Eclipse formatter profile. Issue-Id: #1465
Copy tests `testMultiplePoolNameWithOneCollectorRegistry` and `testMultiplePoolNameWithDifferentCollectorRegistries` from `PrometheusMetricsTrackerTest` to `PrometheusHistogramMetricsTrackerTest` so that we test the same behaviour with regard to `CollectorRegistry` across both implementations. Also port refactorings from 086bf18 to `PrometheusHistogramMetricsTrackerTest` and reformat. Issue-Id: #1465
Port improvements from #1331 (086bf18) to `PrometheusHistogramMetricsTrackerFactory`: add mechanism to avoid registering a `io.prometheus.client.Collector` more than once in the same `io.prometheus.client.CollectorRegistry`. Also reformat `PrometheusHistogramMetricsTrackerFactory` according to this project's Eclipse formatter profile. Issue-Id: #1465
Port improvements from #1331 (086bf18) to `PrometheusHistogramMetricsTracker`: add mechanism to avoid registering a `io.prometheus.client.Collector` more than once in the same `io.prometheus.client.CollectorRegistry`. Rename method `registerHistogram` to `createHistogram` because it doesn't actually register anything. Issue-Id: #1465
edysli
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #1467 +/- ##
============================================
+ Coverage 71.38% 71.68% +0.29%
- Complexity 548 550 +2
============================================
Files 25 25
Lines 2034 2034
Branches 263 264 +1
============================================
+ Hits 1452 1458 +6
+ Misses 439 432 -7
- Partials 143 144 +1
Continue to review full report at Codecov.
|
|
@apodkutin @vanDonselaar since you guys worked on this area of the code before, would you please review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1465 and formats code related to
PrometheusHistogramMetricsTrackeraccording to this project's Eclipse formatter profile.