Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make generated proxy class final #1661

Merged
merged 1 commit into from Jan 7, 2021
Merged

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Sep 23, 2020

The final modifier is overridden by public modifier before this commit

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #1661 into dev will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1661      +/-   ##
============================================
- Coverage     70.11%   70.09%   -0.02%     
  Complexity      561      561              
============================================
  Files            26       26              
  Lines          2118     2117       -1     
  Branches        296      296              
============================================
- Hits           1485     1484       -1     
  Misses          487      487              
  Partials        146      146              
Impacted Files Coverage Δ Complexity Δ
.../com/zaxxer/hikari/util/JavassistProxyFactory.java 88.07% <100.00%> (-0.11%) 35.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c993ef0...643bfab. Read the comment docs.

The final modifier is overridden by public modifier before this commit
@quaff
Copy link
Contributor Author

quaff commented Sep 24, 2020

Could anyone explain why codecov/project failed?

@johnou
Copy link
Contributor

johnou commented Sep 30, 2020

lgtm nice catch! cc @brettwooldridge

@johnou
Copy link
Contributor

johnou commented Jan 7, 2021

ping @brettwooldridge happy new year

@brettwooldridge brettwooldridge merged commit d9983b3 into brettwooldridge:dev Jan 7, 2021
@brettwooldridge
Copy link
Owner

@johnou Happy New Year

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants