Skip to content

Commit

Permalink
revert: "chore: save exclusion rules when bumping the CFN spec (aws#2…
Browse files Browse the repository at this point in the history
…2788)" (aws#23282)

This reverts commit 4e7fdae, because the problem it was intended to solve was fixed in a different way, and this particular approach causes automation to time-out after >1H.


----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Construct Runtime Dependencies:

* [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
RomainMuller authored and Brennan Ho committed Dec 9, 2022
1 parent 41957af commit 90507ad
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions scripts/bump-cfnspec.sh
Expand Up @@ -27,10 +27,6 @@ cd ${pwd}/packages/@aws-cdk/cfnspec
yarn update
version=$(cat cfn.version)

# Running a full build saving awslint exclusion rules in case any of them fails
export AWSLINT_SAVE=true
yarn lerna run build --stream --include-dependencies

# Come back to root, add all files to git and commit
cd ${pwd}
git add .
Expand Down

0 comments on commit 90507ad

Please sign in to comment.