Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the breaking spec in #68
After I changed to
before_validation
, a bunch of specs failed. They failed only because they were usingupdate_attribute
, which skips validation. I replaced all uses ofupdate_attribute
withupdate_attributes
and all tests pass again.I think it's a little odd that setting the position is coupled with running validations. I'm not sure how to resolve that without doing ugly stuff like overriding save...