Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/place new elements in front #113

Closed
wants to merge 4 commits into from

Conversation

emrox
Copy link

@emrox emrox commented Jul 22, 2016

fixes #99 when placing new elements in front (or with the same rank as an already existing)

@emrox
Copy link
Author

emrox commented Sep 18, 2018

Is there any issue with this PR or any reason not to apply it?

@brendon
Copy link
Owner

brendon commented Sep 18, 2018

Hi @emrox, I'm happy to look at this for you. Can you give me a bit more of a detailed rundown of the problem? I've looked at your code and the issue but it's not clear to me if this is a bug.

Are you saying that when you grab an existing items position and set your moving item's position to the existing items position (i.e. push the existing item down the list and insert this moving item there) that it doesn't work as expected?

It's my understanding that you shouldn't use the rank column directly but rather the position pseudo-value. So grab the existing items swimming_rank_position then use that to move the other item.

Let me know your thoughts on that.

@brendon
Copy link
Owner

brendon commented Jun 4, 2024

Closed as abandoned.

@brendon brendon closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when placing new elements at front of list by default
2 participants