Update test_renderer so that tests pass with Sphinx 7.2.
#976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sphinx was updated in in pull request sphinx-doc/sphinx#11526 (July 2023) so that importing `sphinx.testing.path` no longer causes Sphinx application paths to belong to the class `sphinx.testing.path.path`, which has a `makedirs` method. Instead, Sphinx application paths are now ordinary `Path` objects which lack this method, so we use `os.makedirs` instead. This is backwards compatible as `sphinx.testing.path.path` objects are pathlike and so accepted by `os.makedirs`. Fixes issue breathe-doc#975.
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sphinx was updated in in pull request sphinx-doc/sphinx#11526 (July 2023) so that importing
sphinx.testing.pathno longer causes Sphinx application paths to belong to the classsphinx.testing.path.path, which has amakedirsmethod.Instead, Sphinx application paths are now ordinary
Pathobjects which lack this method, so we useos.makedirsinstead. This is backwards compatible assphinx.testing.path.pathobjects are pathlike and so accepted byos.makedirs.