Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track the build/ folder in .git #85

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Track the build/ folder in .git #85

wants to merge 1 commit into from

Conversation

nvonpentz
Copy link
Member

Resolves #83

This will make it easier to cache data fetched during script runtime as well as make it easier to look up the current and past states of the token-lists.

  • Remove npm-publish.yml workflow since it's redundant with the solana-tokenlist.yml workflow.

  • In the solana-tokenlist.yml workflow commit changes to data/ and build folder and push after running the scripts but before publishing.

This will make it easier to cache data fetched during script runtime as
well as make it easier to look up the current and past states of the
token-lists.

* Remove npm-publish.yml workflow since it's redundant with the
  solana-tokenlist.yml workflow.

* In the solana-tokenlist.yml workflow commit changes to data/ and build
  folder and push after running the scripts but before publishing.
@nvonpentz nvonpentz requested a review from onyb August 31, 2023 20:13
Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the npm-publish workflow for now as solana-tokenlist is flaky. It's still a good way to get new releases out without refreshing the solana list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commit the changes to build/ and data/ in the npm-publish github action
2 participants