-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taxonomy update I #701
base: master
Are you sure you want to change the base?
Taxonomy update I #701
Conversation
87a31a2
to
84ee127
Compare
Here's the related BC issue: brave/brave-core#21413. cc @mattmcalister for review. As discussed with @fallaciousreasoning, we are keeping the deprecated channel and will remove it only in the future. cc @fallaciousreasoning could you also review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good to me. I'm tempted to say we shouldn't change the category column at all, as it isn't really used, but whatever you guys reckon is best 😄
Maybe get a sign off from @petemill and @aurangzaib048 before landing this, because maybe they'll think of something I've missed 😄
e7d6d0c
to
58ae0ff
Compare
Removed changes to the deprecated |
does the |
|
Hey, I was thinking about this a bit - I don't think we want to change anything on the backend until all the frontends are updated (and have been updated for a while). brave/brave-core#21413 should fix this on Android & Desktop, but we need to make sure this is fixed on iOS Otherwise we're going to make the situation worse first (i.e. Sport & Sports in more regions). |
Let's hold off on this until the other clients catch up with the migration. |
Sounds perfect, meanwhile I am working on the retiring the old sources files. |
Related to #702
Migration performed:
We also reclassified the following publishers