Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxonomy update I #701

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Taxonomy update I #701

wants to merge 2 commits into from

Conversation

LorenzoMinto
Copy link
Member

@LorenzoMinto LorenzoMinto commented Dec 18, 2023

Related to #702

Migration performed:

From To locales affected
Entertainment News Celebrities, Entertainment US
Celebrity News Celebrities AU, IN, FR
Tech News Technology US
Tech Reviews Technology US
Sport Sports DE

We also reclassified the following publishers

Publisher From To
Byrdie Health Fashion
Hollywood Reporter Entertainment Film and TV
Variety Entertainment Film and TV
Deadline Entertainment Film and TV
Looper Entertainment Film and TV
The Wrap Entertainment Film and TV

@LorenzoMinto
Copy link
Member Author

Here's the related BC issue: brave/brave-core#21413. cc @mattmcalister for review.

As discussed with @fallaciousreasoning, we are keeping the deprecated channel and will remove it only in the future.

cc @fallaciousreasoning could you also review

Copy link
Collaborator

@fallaciousreasoning fallaciousreasoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to me. I'm tempted to say we shouldn't change the category column at all, as it isn't really used, but whatever you guys reckon is best 😄

Maybe get a sign off from @petemill and @aurangzaib048 before landing this, because maybe they'll think of something I've missed 😄

@LorenzoMinto LorenzoMinto self-assigned this Dec 19, 2023
@LorenzoMinto
Copy link
Member Author

Removed changes to the deprecated category field to avoid any potential back-compatibility issues. @fallaciousreasoning where is the channels "ground-truth" taken from on the client?

@mattmcalister
Copy link
Collaborator

does the Sport -> Sports need to happen in any other regions, like GB?

@LorenzoMinto
Copy link
Member Author

en_GB already uses Sports

@fallaciousreasoning
Copy link
Collaborator

Hey, I was thinking about this a bit - I don't think we want to change anything on the backend until all the frontends are updated (and have been updated for a while).

brave/brave-core#21413 should fix this on Android & Desktop, but we need to make sure this is fixed on iOS

Otherwise we're going to make the situation worse first (i.e. Sport & Sports in more regions).

@LorenzoMinto
Copy link
Member Author

Let's hold off on this until the other clients catch up with the migration.

@LorenzoMinto LorenzoMinto marked this pull request as draft January 4, 2024 11:21
@aurangzaib048
Copy link
Member

Sounds perfect, meanwhile I am working on the retiring the old sources files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants