-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resize the image using parameters and add image size in feed.json #86
Comments
I'm not so sure we need the |
Suggestion:
|
@aurangzaib048 I don't see any PRs for this. did you already do this? if so, can you please point to it here and close the issue? |
@mattmcalister This is very critical because we have too many possible parameters in the image URL for image size.
In contract I have improved the image selection criteria here. Now we are getting the best quality image. |
Hey, just looking at that code for pulling out the image, it doesn't look like we do any resizing, and it doesn't look like we pick the largest image either (for example, the image at
Yeah, I agree, there are a lot of potential ways to request different sized images but I think @petemill was suggesting we just do it on the padded CDN images (where we would control the parameters)? |
Hey @fallaciousreasoning The
And we can’t control the parameters in the padded images. |
While process the images try to reduce the size of the images the optimal size,
width
andheight
it should be reduced to (ask from @petemill/ @fallaciousreasoning )resize
it should be reduced to (ask from @petemill/ @fallaciousreasoning )As well as add a field for
img_size
infeed.json
so that client is well aware of the size of the image and decide whether to show or not.The text was updated successfully, but these errors were encountered: