Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image width and height to feed items for improved handling on the client #683

Open
Tracked by #679
LorenzoMinto opened this issue Dec 5, 2023 · 2 comments
Open
Tracked by #679

Comments

@LorenzoMinto
Copy link
Member

LorenzoMinto commented Dec 5, 2023

For each img we should add height and width fields, which will help the client make the decision on whether those cards should be shown as heroes or small cards. cc @petemill @fallaciousreasoning

@aurangzaib048
Copy link
Member

aurangzaib048 commented Dec 5, 2023

We can’t add or update/change the image url by updating the height and width , for example

P.S: As I have stated in #86 (comment), it is possible that the updated URL can be 404 Not Found.

@LorenzoMinto
Copy link
Member Author

LorenzoMinto commented Dec 5, 2023

That's more related to the other sub-issue: improving the image selection process. This issue is about adding height and width fields to the image in the articles in the feed so that the client can make an informed decision on how to show it. Once we have selected an image, we download it and it should be trivial to get its size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants