Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and cleanup Jest JSDOM environment setup. #23665

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

goodov
Copy link
Member

@goodov goodov commented May 15, 2024

Changes in this PR:

  1. Use JSDOM().window created by JSDOMEnvironment, do not create another instance of JSDOM in testPolyfills.ts.
  2. Throw on jsdomError to expose JSDOM errors instead of burying them in the log output.
  3. Add missing window.* APIs using node-provided counterparts (webcrypto, etc.).
  4. Move loadTimeData data into testData.ts.
  5. Disable coverage generation by default as it creates a lot of extra output, but seems like it's not used anywhere. It can be enabled manually by passing --coverage.

Resolves brave/brave-browser#38362

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label May 15, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@goodov goodov force-pushed the jest-environment-fixes branch 2 times, most recently from ccbc6b2 to 9569087 Compare May 16, 2024 07:59
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@goodov goodov marked this pull request as ready for review May 16, 2024 10:01
@goodov goodov requested a review from a team as a code owner May 16, 2024 10:01
@goodov goodov changed the title Use JSDOMEnvironment properly, disable coverage generation, add ignores. Fix and cleanup Jest JSDOM environment process. May 16, 2024
@goodov goodov changed the title Fix and cleanup Jest JSDOM environment process. Fix and cleanup Jest JSDOM environment setup. May 16, 2024
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@goodov goodov merged commit c5402bc into master May 17, 2024
19 checks passed
@goodov goodov deleted the jest-environment-fixes branch May 17, 2024 06:55
@github-actions github-actions bot added this to the 1.68.x - Nightly milestone May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
4 participants