-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and cleanup Jest JSDOM environment setup. #23665
Conversation
A Storybook has been deployed to preview UI for the latest push |
b055704
to
8950803
Compare
A Storybook has been deployed to preview UI for the latest push |
8950803
to
393edfb
Compare
A Storybook has been deployed to preview UI for the latest push |
393edfb
to
b23c9ca
Compare
ccbc6b2
to
9569087
Compare
9569087
to
ed80e99
Compare
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Changes in this PR:
JSDOM().window
created byJSDOMEnvironment
, do not create another instance ofJSDOM
intestPolyfills.ts
.jsdomError
to expose JSDOM errors instead of burying them in the log output.window.*
APIs using node-provided counterparts (webcrypto
, etc.).loadTimeData
data intotestData.ts
.--coverage
.Resolves brave/brave-browser#38362
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: