Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for Index other search engine #23659

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented May 15, 2024

Resolves brave/brave-browser#38129

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Index other search engines option inside Search engines should be disabled by default to match with desktop.

@deeppandya deeppandya added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels May 15, 2024
@deeppandya deeppandya added this to the 1.68.x - Nightly milestone May 15, 2024
@deeppandya deeppandya self-assigned this May 15, 2024
@deeppandya deeppandya requested a review from a team as a code owner May 15, 2024 00:07
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++

Copy link
Contributor

@tapanmodh tapanmodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton enabled auto-merge May 16, 2024 22:26
@bsclifton
Copy link
Member

bsclifton commented May 16, 2024

Looks like we have a presubmit error w/ gn check.

ERROR at //brave/browser/search_engines/private_window_search_engine_provider_service_android.cc:11:11: Include not allowed.
#include "components/search_engines/search_engines_pref_names.h"
          ^----------------------------------------------------
  It is not in any dependency of
  //chrome/browser:browser
  The include file is in the target(s):
  //brave/browser/android/preferences:java_pref_names_srcjar
  which should somehow be reachable.
___________________
ERROR at //brave/browser/search_engines/normal_window_search_engine_provider_service_android.cc:14:11: Include not allowed.
#include "components/search_engines/search_engines_pref_names.h"
          ^----------------------------------------------------
  It is not in any dependency of
  //chrome/browser:browser
  The include file is in the target(s):
  //brave/browser/android/preferences:java_pref_names_srcjar
  which should somehow be reachable.
___________________
ERROR at //brave/browser/search_engines/search_engine_provider_service_factory.cc:19:11: Include not allowed.
#include "components/search_engines/search_engines_pref_names.h"
          ^----------------------------------------------------
  It is not in any dependency of
  //chrome/browser:browser
  The include file is in the target(s):
  //brave/browser/android/preferences:java_pref_names_srcjar
  which should somehow be reachable.
___________________
ERROR at //brave/browser/profiles/profile_util_unittest.cc:16:11: Can't include this header from here.
#include "components/search_engines/search_engines_pref_names.h"
          ^----------------------------------------------------
  The target:
  //brave/test:brave_unit_tests__library
  is including a file from the target:
  //brave/browser/android/preferences:java_pref_names_srcjar
  
  It's usually best to depend directly on the destination target.
In some cases, the destination target is considered a subcomponent
of an intermediate target. In this case, the intermediate target
should depend publicly on the destination to forward the ability
to include headers.

Dependency chain (there may also be others):
  //brave/test:brave_unit_tests__library -->
  //brave/test:brave_public_test_apk --[private]-->
  //chrome/browser/settings:test_support_java -->
  //chrome/browser/settings:test_support_java__dex --[private]-->
  //chrome/android:chrome_java__header --[private]-->
  //brave/browser/android/preferences:java_pref_names_srcjar

@deeppandya deeppandya disabled auto-merge May 16, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
4 participants