Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Update User Agent to 17.5 #23652

Merged
merged 1 commit into from
May 16, 2024
Merged

[iOS] Update User Agent to 17.5 #23652

merged 1 commit into from
May 16, 2024

Conversation

iccub
Copy link
Contributor

@iccub iccub commented May 14, 2024

Resolves brave/brave-browser#38322

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Verify that Safari on iOS 17.5 and Brave on any iOS 17 build uses the same user agent, both mobile and desktop UA

@iccub iccub requested a review from a team as a code owner May 14, 2024 19:39
@iccub iccub added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels May 14, 2024
@iccub iccub merged commit 65b50d4 into master May 16, 2024
20 checks passed
@iccub iccub deleted the bugfix/38322 branch May 16, 2024 13:24
@github-actions github-actions bot added this to the 1.68.x - Nightly milestone May 16, 2024
brave-builds added a commit that referenced this pull request May 16, 2024
@kjozwiak
Copy link
Member

Verification PASSED on iPhone 11 running iOS 17.5.1 using the following build(s):

1.68.36 Chromium: 125.0.6422.76 (Official Build) nightly (64-bit)
--- | ---
Revision | e4a82b7ddcc2...
OS | iOS

Using the STR/information outlined via #23652 (comment), ensured that the US for iOS is using 17.5 and matches Safari as per the following:

Safari (Mobile) Safari (Desktop)
IMG_0249 IMG_0250
Brave (Mobile) Brave (Desktop)
IMG_0251 IMG_0252

kjozwiak pushed a commit that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
4 participants