Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aichat: conversation layout updates #23651

Merged
merged 3 commits into from
May 20, 2024
Merged

aichat: conversation layout updates #23651

merged 3 commits into from
May 20, 2024

Conversation

nullhook
Copy link
Contributor

@nullhook nullhook commented May 14, 2024

Resolves brave/brave-browser#37792

  • new conversation layout updates
  • yes, this has formatting changes

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label May 14, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@nullhook nullhook requested a review from petemill May 15, 2024 21:44
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!
image
image

The one piece of feedback I have is about the spacing between the entry and the search summary. I think it should change from margin-top: 16px to margin-top: var(--leo-spacing-m) to keep its relationship with its entry.

image

And the only other thing I noticed is the large spacing at the top between the model intro and the conversation. It feels more noticeable now since there's more space with the first wide line pushed lower. Seems like we can remove some of this gap. Confusingly when I look in Figma, I don't see the model intro anymore, so maybe we're meant to remove it @aguscruiz? Not yet?

image

@nullhook
Copy link
Contributor Author

fixed spacing entry and search search summary. also, model intro has been tweaked.

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@nullhook nullhook merged commit 4cbaf0e into master May 20, 2024
19 checks passed
@nullhook nullhook deleted the aichat-new-layout branch May 20, 2024 14:47
@github-actions github-actions bot added this to the 1.68.x - Nightly milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
3 participants