Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fix Refresh credentials flow for mobile users #23649

Merged
merged 7 commits into from
May 23, 2024

Conversation

soner-yuksel
Copy link
Member

@soner-yuksel soner-yuksel commented May 14, 2024

Resolves brave/brave-browser#38086

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan - Screenshot:

This is just for linking. It is an another entry point for "Link Purchase to Your Brave Account" like in VPN settings. We are adding them both in Leo and VPN paywalls.

The difference is where user is redirected, which is a site where they can only do linking and cant navigate to any purchase.

VPN - Leo

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-05-14.at.13.49.02.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-05-14.at.13.50.30.mp4

test1

@soner-yuksel soner-yuksel added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels May 14, 2024
@soner-yuksel soner-yuksel self-assigned this May 14, 2024
@soner-yuksel soner-yuksel marked this pull request as ready for review May 14, 2024 17:55
@soner-yuksel soner-yuksel requested a review from a team as a code owner May 14, 2024 17:55
Copy link
Contributor

@iccub iccub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's wait with merging until security review passes

@soner-yuksel soner-yuksel force-pushed the ios/enhancement/vpn-refresh-credentials branch from c0ea6fd to 75d84de Compare May 20, 2024 18:00
@soner-yuksel soner-yuksel force-pushed the ios/enhancement/vpn-refresh-credentials branch from 1e7b82c to 9890609 Compare May 23, 2024 13:23
@soner-yuksel soner-yuksel merged commit fd85b1b into master May 23, 2024
19 checks passed
@soner-yuksel soner-yuksel deleted the ios/enhancement/vpn-refresh-credentials branch May 23, 2024 15:15
@github-actions github-actions bot added this to the 1.68.x - Nightly milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 needs-security-review
Projects
None yet
5 participants