Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(wallet): Ellipsis Token Names in Swap and Send #23648

Merged

Conversation

Douglashdaniel
Copy link
Contributor

Description

Will now add an ellipsis to token names in the Swap and Send Select Token Modal

Resolves brave/brave-browser#38064

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open the Wallet Panel and navigate to the Swap screen
  2. Open the Select Token Modal
  3. Tokens with long names should have an ellipsis applied to them.

Before:

Screenshot 43

After:

Screenshot 42

@Douglashdaniel Douglashdaniel self-assigned this May 14, 2024
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner May 14, 2024 16:34
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels May 14, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel force-pushed the style-wallet-ellipsis-token-names-in-swap-and-send branch from 9307589 to 98a53cf Compare May 15, 2024 12:46
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel merged commit 3a7b247 into master May 15, 2024
19 checks passed
@Douglashdaniel Douglashdaniel deleted the style-wallet-ellipsis-token-names-in-swap-and-send branch May 15, 2024 16:02
@github-actions github-actions bot added this to the 1.68.x - Nightly milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
3 participants