Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create AcceleratorService for Guest profile. #23644

Merged
merged 1 commit into from
May 15, 2024

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented May 14, 2024

Resolves brave/brave-browser#31025

Removed AcceleratorService from Guest profiles because:

  1. Guest profiles are meant for users unrelated to the regular profile user (so it's unlikely they would want the same keyboard shortcuts changes)
  2. There is no UI in the Guest profile Settings to modify the shortcuts.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin added the CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) label May 14, 2024
@mkarolin mkarolin self-assigned this May 14, 2024
@mkarolin mkarolin marked this pull request as ready for review May 14, 2024 18:09
@mkarolin mkarolin merged commit 61287c0 into master May 15, 2024
19 checks passed
@mkarolin mkarolin deleted the maxk-no-accelerator-service-in-guest branch May 15, 2024 17:15
@mkarolin mkarolin added this to the 1.68.x - Nightly milestone May 15, 2024
@github-actions github-actions bot added this to the 1.68.x - Nightly milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
2 participants