Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Fixes same document navigations should trigger NotifyTabDidChange #23643

Closed
wants to merge 1 commit into from

Conversation

aseren
Copy link
Collaborator

@aseren aseren commented May 14, 2024

Resolves brave/brave-browser#38272

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

tabManager.selectedTab?.reportPageNavigation(to: rewards)
tab.reportPageNavigation(to: rewards)

rewards.reportTabUpdated(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be discussed and re-thought because can possibly break site visits when navigating to the same eTLD+1

// Not passing redirection chain here, in page navigation should not use them.
tabManager.selectedTab?.reportPageLoad(to: rewards, redirectChain: [])
tab.reportPageLoad(to: rewards, redirectChain: [])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with desktop/Android we should still pass the redirect chain.

@aseren
Copy link
Collaborator Author

aseren commented May 29, 2024

The original issue is caused by same document navigation detection implementation on iOS and should be fixed after proper same document navigation implementation.
So the original issue is blocked until brave/brave-browser#38662 is resolved.

@aseren aseren closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants