Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Jest Teamcity reporter #23642

Merged
merged 1 commit into from
May 28, 2024
Merged

Add Jest Teamcity reporter #23642

merged 1 commit into from
May 28, 2024

Conversation

goodov
Copy link
Member

@goodov goodov commented May 14, 2024 •
edited

Changes in this PR:

  1. Add Jest reporter to report test results via Teamcity Service Messages.
  2. Enable the reporter via Jest configuration on Teamcity.
  3. Fix transform regex to match actual source files (skip .json for ex.).

Related brave/brave-browser#30125

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/teamcity Run builds in TeamCity labels May 14, 2024
@goodov goodov self-assigned this May 14, 2024
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label May 14, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@goodov goodov force-pushed the issues/30125/jest-tc-reporter branch from ee25883 to b68eeb6 Compare May 14, 2024 14:58
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@goodov goodov force-pushed the issues/30125/jest-tc-reporter branch 2 times, most recently from 1815aef to a90463c Compare May 15, 2024 08:11
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@goodov goodov removed the CI/storybook-url Deploy storybook and provide a unique URL for each build label May 15, 2024
@goodov goodov force-pushed the issues/30125/jest-tc-reporter branch from a90463c to f19c915 Compare May 15, 2024 11:37
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels May 15, 2024
@goodov goodov force-pushed the issues/30125/jest-tc-reporter branch 2 times, most recently from 466d40b to 606254c Compare May 15, 2024 12:35
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@goodov goodov force-pushed the issues/30125/jest-tc-reporter branch from 606254c to 0325f9d Compare May 17, 2024 08:44
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@goodov goodov force-pushed the issues/30125/jest-tc-reporter branch from 0325f9d to 675d664 Compare May 17, 2024 11:04
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@goodov goodov force-pushed the issues/30125/jest-tc-reporter branch from 675d664 to 4f6fd92 Compare May 17, 2024 12:17
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@goodov goodov force-pushed the issues/30125/jest-tc-reporter branch 2 times, most recently from 14cd43d to 45536e5 Compare May 17, 2024 14:34
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@goodov goodov force-pushed the issues/30125/jest-tc-reporter branch from 45536e5 to 3614d7a Compare May 17, 2024 14:58
@goodov goodov force-pushed the issues/30125/jest-tc-reporter branch from c5d8de2 to 80ed8a1 Compare May 21, 2024 15:04
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@goodov goodov force-pushed the issues/30125/jest-tc-reporter branch 2 times, most recently from 80ed8a1 to 6460ac5 Compare May 22, 2024 09:48
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@goodov goodov force-pushed the issues/30125/jest-tc-reporter branch 6 times, most recently from e641718 to d635cd1 Compare May 23, 2024 07:51
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@goodov goodov force-pushed the issues/30125/jest-tc-reporter branch from d635cd1 to 2d3b500 Compare May 23, 2024 11:00
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@goodov goodov force-pushed the issues/30125/jest-tc-reporter branch from 2d3b500 to 16f187b Compare May 23, 2024 15:02
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@goodov goodov marked this pull request as ready for review May 24, 2024 05:38
@goodov
Copy link
Member Author

goodov commented May 24, 2024

Results reported as test-unit suite in Teamcity: https://teamcity.brave.com/buildConfiguration/BraveBrowser_Linux_X64_Aggregate/27759?buildTab=tests&view=packages&suite=test-unit%3A+

fallaciousreasoning
fallaciousreasoning approved these changes May 26, 2024
View reviewed changes
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄 The sooner Teamcity is working, the better!

tools/jest_teamcity_reporter/jest_teamcity_reporter.js Show resolved Hide resolved
tools/jest_teamcity_reporter/jest_teamcity_reporter.js Show resolved Hide resolved
@goodov goodov force-pushed the issues/30125/jest-tc-reporter branch from 16f187b to 5dfb275 Compare May 27, 2024 06:20
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@goodov goodov merged commit 8a13b6c into master May 28, 2024
20 checks passed
@goodov goodov deleted the issues/30125/jest-tc-reporter branch May 28, 2024 05:04
@github-actions github-actions bot added this to the 1.68.x - Nightly milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fallaciousreasoning fallaciousreasoning fallaciousreasoning approved these changes

@petemill petemill Awaiting requested review from petemill

@josheleonard josheleonard Awaiting requested review from josheleonard

@wknapik wknapik Awaiting requested review from wknapik

Assignees

@goodov goodov

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/storybook-url Deploy storybook and provide a unique URL for each build CI/teamcity Run builds in TeamCity
Projects
None yet
Milestone
1.68.x - Nightly
3 participants
@goodov @brave-builds @fallaciousreasoning