-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Wallet) Implement mitigation for null password issue #23641
Conversation
The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "password" and so security team members have been added as reviewers to take a look. |
664fe03
to
921b481
Compare
...omium/chrome/browser/crypto_wallet/fragments/onboarding/OnboardingRestoreWalletFragment.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
This pull request fixes an issue we wanted to uplift. For security reviewer: feel free to verify further, but I think a security review is not needed here. |
kicked off a build for this tonight so I can test this in the morning. From a quick look at the code I'm not seeing any issues so far |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and not seeing any issues.
Resolves brave/brave-browser#38224
Resolves brave/brave-browser#38220
Resolves brave/brave-browser#35297
Implement a mitigation for an issue that may cause an illegal state exception during Wallet creation.
When brave/brave-browser#35294 will be completed the Wallet restoration (that most likely was causing the issue) will be refactored.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Account Recovery Steps