Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set GoogleSignInPermission to be Enabled by default #23621

Merged
merged 1 commit into from
May 24, 2024

Conversation

ShivanKaul
Copy link
Collaborator

@ShivanKaul ShivanKaul commented May 13, 2024

Now that the feature is 100% on Release, can be enabled by default.

Resolves brave/brave-browser#38296

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Now that the feature is 100% on Release, can be enabled by default.
@ShivanKaul ShivanKaul force-pushed the enable-google-sign-in-permission-by-default branch from 5562500 to e50ab20 Compare May 24, 2024 00:18
@ShivanKaul ShivanKaul merged commit c34a9aa into master May 24, 2024
19 checks passed
@ShivanKaul ShivanKaul deleted the enable-google-sign-in-permission-by-default branch May 24, 2024 15:59
@github-actions github-actions bot added this to the 1.68.x - Nightly milestone May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants