Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a comment for ShowSingletonTab overrides. #23620

Merged
merged 1 commit into from
May 14, 2024

Conversation

mkarolin
Copy link
Collaborator

Resolves brave/brave-browser#31826

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin self-assigned this May 13, 2024
@mkarolin mkarolin requested a review from a team as a code owner May 13, 2024 22:20
@mkarolin mkarolin force-pushed the maxk-singleton-tabs-comment branch from 398f0a4 to b58fab8 Compare May 14, 2024 01:04
@mkarolin mkarolin merged commit 25575fa into master May 14, 2024
18 checks passed
@mkarolin mkarolin deleted the maxk-singleton-tabs-comment branch May 14, 2024 13:15
@mkarolin mkarolin added this to the 1.68.x - Nightly milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants