Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] fix multiple window dialog text cutoff #23617

Merged
merged 1 commit into from
May 15, 2024

Conversation

tapanmodh
Copy link
Contributor

Resolves brave/brave-browser#38269

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Please check issue for test plan

@tapanmodh tapanmodh added this to the 1.68.x - Nightly milestone May 13, 2024
@tapanmodh tapanmodh self-assigned this May 13, 2024
@@ -39,7 +39,7 @@

<android.widget.Button
android:id="@+id/btn_merge"
android:layout_width="wrap_content"
android:layout_width="0dp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we limit the text to num of lines ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's good idea. may be max 2 lines. wdyt?

@tapanmodh tapanmodh force-pushed the fix_multiple_window_dialog_text_cutoff branch from b239c85 to a8abdb1 Compare May 15, 2024 11:41
Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tapanmodh tapanmodh merged commit b511be3 into master May 15, 2024
19 checks passed
@tapanmodh tapanmodh deleted the fix_multiple_window_dialog_text_cutoff branch May 15, 2024 16:02
brave-builds added a commit that referenced this pull request May 15, 2024
brave-builds added a commit that referenced this pull request May 15, 2024
@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 using version

Brave	1.68.19 Chromium: 125.0.6422.41 (Official Build) canary (64-bit) 
Revision	27e9c4655eb07c8e606bdd56add4e4b13c2c3fb6
OS	Android 13; Build/TP1A.220624.014; 33; REL

  • Ensured that button text is visible on the dialog and not cut off completely.
  • Ensured buttons on the dialog work in split screen and fullscreen view.
1.68.18 1.68.19 Full screen (1.68.19) 'Move to other window' page (1.68.19) Brave://version
Screenshot 2024-05-15 at 4 00 29 PM Screenshot 2024-05-15 at 4 02 41 PM Screenshot 2024-05-15 at 4 02 51 PM Screenshot 2024-05-15 at 4 07 58 PM Screenshot 2024-05-15 at 4 03 10 PM

kjozwiak pushed a commit that referenced this pull request May 15, 2024
kjozwiak pushed a commit that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants